test: Fix flaky session tracker tests#2198
Merged
philipphofmann merged 5 commits intomasterfrom Sep 21, 2022
Merged
Conversation
Fix flaky SessionTrackerTests in CI by adding an abstraction.
philipphofmann
changed the title
philipphofmann
requested review from
armcknight,
brustolin and
indragiek
as code owners
Member
|
Looking back at my attempt to use expectations to wait for the async delivery of these notifications (edd4706), and I just realized I never actually fulfilled them in those test cases 😕 Gotta use expectations (and correctly haha) for async api like this |
Member
Author
|
I also tried the expectations, but it didn't work. I have no clue what the issue is, but not it works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Testing with NSNotificationCenter in CI leads to flaky tests.
Therefore, we use a wrapper around NSNotificationCenter to not
depend on it. Instead, we call the methods NSNotificationCenter
would call with Dynamic and ensure that sut properly subscribes
to NSNotificationCenter.
#skip-changelog
💡 Motivation and Context
Fixes #2062
💚 How did you test it?
Unit tests.
📝 Checklist
🔮 Next steps